Smokers specifically are very much a net cost to society, because smoking kills slowly and in a very expensive manner.

In any case, anything that makes people die young, or more generally reduces people’s capacity to work (like many diseases of affluence) is incredibly expensive to society once you factor in indirect and opportunity costs.