I tried that but the downloads time out for me a few hundred in, and the nature of the script is such that it doesn’t auto restart or crash but it hangs and needs manual interactive intervention.
I'm running it in a container. So I haven't noticed any such issues. Other than having to re-authenticate every few weeks. The container itself is configured to auto restart on failures. But I'll keep an eye on it. Maybe it is failing and I just never noticed it. But I do see that my NAS has the latest images and videos downloaded. So at least as a container, its working as advertised.
https://github.com/icloud-photos-downloader/icloud_photos_do...