I'm not sure about their legality over the years, but I do know that they were in fact largely accessible and were and extremely important avenue for academic researchers to engage with the broader community. This ban will likely disproportionally effect China's elites, who have long used VPNs for many reasons unrelated to politics.